#6456: Upgrade cvxopt in sage from 0.9 to 1.1.3
--------------------------------+-------------------------------------------
Reporter: was | Owner: mabshoff
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: packages | Keywords:
Author: schilly, dimpase | Upstream: Completely fixed; Fix reported
upstream
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Comment(by drkirkby):
A few comments.
* I changed the title, since this is a new version.
* There's a file {{{patches/setup.py.orig}}} which is not in the
repository. What is this .orig supposed to be? Is it from the old version
of this package, since it is totally different from the setup.py in the
source files. If its only from the previous version of the package, it
serves no real useful purpose and can be deleted.
{{{
-rw-r--r-- 1 drkirkby staff 5701 Sep 16 05:55 ./src/src/setup.py
-rw-r--r-- 1 drkirkby staff 5648 Oct 12 00:53
./patches/setup.py.patch
-rw-r--r-- 1 drkirkby staff 6226 Oct 12 01:09 ./patches/setup.py
-rw-r--r-- 1 drkirkby staff 6228 Oct 12 01:06
./patches/setup.py.orig
}}}
* The modification time of ./patches/setup.py.patch is Oct 12 00:53, yet
the file that should be created from, ./patches/setup.py was last edited
16 minute later. I'm a bit suspicious of how this package has been
patched,
* The description in SPKG.txt could be a lot more informative. There's a
much better description in the file {{{setup.py}}}.
* It would be sensible to list the author's email addresses in the
'Upstream Contact' section of SPKG.txt. They are in the file setup.py.
* The entry for cvxopt-1.1.2 in SPKG.txt should be removed, since 1.1.2
was never merged into Sage at all. All the changes should be under the
1.1.3 section.
* All the "TODO" items in SPKG.txt would be better moved to the special
build instructions section of SPKG.txt, since they have not been done,
they should not be done in the ChangeLog, which should document changes
made.
* Some of the TODO items '''must''' be done now, and can't be left. For
example, this is now linking against both GSL and GLPK, so adding those
dependencies to the file {{{spkg/standard/deps}}} must be listed as a
change that has been made, rather than a TODO.
* I've attached a revised spkg/standard/deps which makes sure that both
GSL and GLPK are built before cvxopt.
* All the authors who have contributed should be listed in SPKG.txt.
There are several missing, including myself, Peter Jeremy and perhaps
others.
* The authors field on here needs to have the full names of people, not
their user names.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6456#comment:100>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
