#10129: citation.pyx: don't return false positives based on path
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: jason
Type: defect | Status: needs_review
Priority: trivial | Milestone: sage-4.6.1
Component: misc | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by jhpalmieri):
* status: new => needs_review
Old description:
> If you build Sage in a path containing "numpy", then {{{get_systems}}} in
> citation.pyx will think that numpy is used in every command, because it
> does a regular expression search for "numpy" using full pathnames. The
> attached patch replaces SAGE_ROOT with an empty string, to avoid such
> false positives.
New description:
If you build Sage in a path containing "numpy", then {{{get_systems}}} in
citation.pyx will think that numpy is used in every command, because it
does a regular expression search for "numpy" using full pathnames. The
attached patch replaces SAGE_ROOT with an empty string, to avoid such
false positives.
To test, move an existing Sage installation to
/tmp/numpy/sage-4.6.alpha3/, doctest citation.pyx, apply the patch and
doctest again. (Other strings which will trigger a failure: scipy,
_libsingular, _flint; see the full list at the top of misc/citation.pyx.)
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10129#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
