#9799: Running "make" in SAGE_ROOT returns the wrong exit code, leading to all
kinds of confusion
------------------------------+---------------------------------------------
Reporter: was | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.6
Component: build | Keywords: makefile
Author: John Palmieri | Upstream: N/A
Reviewer: Jeroen Demeyer | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by newvalueoldvalue):
* keywords: => makefile
* reviewer: => Jeroen Demeyer
* author: => John Palmieri
Comment:
I have read the patch and it looks okay to me, but perhaps somebody who is
more familiar with the Sage build process should have a second look. I am
currently doing a full build from scratch with the new {{{Makefile}}}
(with capital). I have a few comments (which you're free to ignore...).
Why not leave
{{{
all: build doc
}}}
as it is? I agree that "build" is superfluous, but I think it adds
clarity. It is also more robust in case other parts of the makefile are
changed.
the same for
{{{
doc-html: build # (already) indirectly depends on $(PIPE)
}}}
About the comments: I think it more common to put them outside the make
rules, so instead of
{{{
build: $(PIPE)
@# Note that (currently) "tee" will be run in the directory cd'ed to
@# in pipestatus' first argument, i.e. "spkg/":
$(PIPE) "cd spkg && ./install all 2>&1" "tee -a ../install.log"
}}}
why not write
{{{
# Note that (currently) "tee" will be run in the directory cd'ed to
# in pipestatus' first argument, i.e. "spkg/":
build: $(PIPE)
$(PIPE) "cd spkg && ./install all 2>&1" "tee -a ../install.log"
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9799#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
