#3416: Weierstrass form for cubics
-----------------------------+----------------------------------------------
   Reporter:  moretti        |       Owner:  was                                
                       
       Type:  enhancement    |      Status:  needs_review                       
                       
   Priority:  major          |   Milestone:  sage-4.6                           
                       
  Component:  number theory  |    Keywords:  nagell, weierstrass, cubic, 
elliptic curves, editor_wstein
     Author:                 |    Upstream:  N/A                                
                       
   Reviewer:                 |      Merged:                                     
                       
Work_issues:                 |  
-----------------------------+----------------------------------------------

Comment(by cremona):

 Just a couple of quick comments, as I have not yet had a chance to look at
 the patch properly or try it out.  First:  I'm not sure we really want my
 old lecture notes attached to this ticket!  There is nothing you are using
 there that is not in standard other sources.  But if they are there, they
 should be attributed ;)

 Secondly, you absolutely cannot have print statements giving part of the
 output as a side-effect.  Better to return a tuple consisting of the
 elliptic curve and the morphisms.  This will break backwards
 compatibility, since the Magma version does not so this (though he
 underlying Magma function surely does), but it could be controlled by an
 extra parameter which defaults to False.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3416#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to