#8807: Adding support for morphisms to the category framework
---------------------------+------------------------------------------------
Reporter: SimonKing | Owner: Simon King
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: categories | Keywords: morphisms functors categories
Author: Simon King | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Changes (by cremona):
* status: needs_review => needs_work
Comment:
Review:
Just a few trivial comments, after which I could give this a positive
review. The patch applies fine to 4.6.rc0 (though the related one at
#8800 does not then apply cleanly) and all tests pass. There is no time
regression (long tests took 667s before and 642s after, using -tp 20).
Here are the minor issues in docstrings:
line 44: "one should implement two methods" -- do you mean three?
_apply_functor_to_morphism: first line of docstring is a copy from the
previous function but should presumably be "Apply the functor to a
morphism between ... something"
In the new {{{__call__}}} function, I would like to see a test of the
branch which raises a {{{TypeError}}} ""%s is ill-defined, ..."
Is the spelling of "{{{CompositConstructionFunctor}}}" intentional?
Should it not be "{{{CompositeConstructionFunctor}}}"?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8807#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
