#10096: sha().an() assumes E is minimal.
-------------------------------+--------------------------------------------
Reporter: weigandt | Owner: cremona
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6
Component: elliptic curves | Keywords: elliptic curves, sha, real period
Author: John Cremona | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by newvalueoldvalue):
* status: new => needs_review
* author: => John Cremona
Comment:
The patch fixes this. the minimal model is computed on construction and
used in place of the original (when the latter is not minimal). New
doctests show that the reported problem has gone away.
It would be helpful if someone could confirm that this is the correct
thing to do also for the an_padic() function. The doctests still pass,
but I sust[ect that they are all with minimal curves anyway. I was
assuming (a) that the value of an_padic() was isomorphism-invariant, and
(2) that using a minimal model would be at least as fast, possibly faster,
than using a non-minimal model, even if both give the correct answer!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10096#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
