#10024: dump()/dumps() fails for class Polyhedron
----------------------------------+-----------------------------------------
Reporter: terhorst | Owner: mhampton
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-4.6.1
Component: geometry | Keywords: polyhedron polyhedra pickle
dumps dump
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Changes (by novoselt):
* status: needs_review => positive_review
* reviewer: => Andrey Novoseltsev
Comment:
1. I think `__setstate__` would look better without checks for
`exclude_keys` which is unnecessary.
1. Equality/"non-equality" tests seem to be not the most efficient ones,
although for generic polyhedra it is not obvious what one should do
instead.
1. Chosen definition of `==`, i.e. equality as sets of points, fits
nicely together with other containment checks, but is inconsistent with
the current situation for cones and fans. This bugs me a little bit, but
not too much and I still prefer cones to take into account the ray order.
Anyway, all this is more like just thinking aloud, I am satisfied with the
patch as is and switching it to positive review! (But feel free to address
the first issue if you want ;-))
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10024#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
