#10188: mpir spkg needs update for Fedora 14
----------------------------+-----------------------------------------------
   Reporter:  vbraun        |       Owner:  tbd         
       Type:  defect        |      Status:  needs_review
   Priority:  major         |   Milestone:  sage-4.6.1  
  Component:  packages      |    Keywords:              
     Author:  Volker Braun  |    Upstream:  N/A         
   Reviewer:                |      Merged:              
Work_issues:                |  
----------------------------+-----------------------------------------------

Comment(by leif):

 It's IMHO cleaner (and more robust) to add
 {{{
 #!sh
 case "$UNAME" in
     Linux) # implies a GNU linker
         LDFLAGS="$LDFLAGS -Wl,z,noexecstack"
         # already exported by sage-env
         ;;
     # perhaps other platforms, too
 esac
 }}}

 Note that the above doesn't depend on the GCC version (or the compiler in
 general; the flag to pass options to the linker might of course differ
 though, but that's probably handled by libtool).

 Even the Sun linker might support that, though it is currently not an
 issue on [Open]Solaris.

 Older versions of the GNU linker will silently ignore this option, i.e.
 its parameter (`noexecstack`); on such systems it is unlikely that
 requiring an executable stack will cause problems anyway.

 Also, using the `execstack` tool requires having it installed on any build
 system one builds bdists on, if they are also targeted at e.g. Fedora 14,
 or other SELinux-enabled systems.
 {{{
     type -P execstack &>/dev/null && ...
 }}}
 won't raise an error or give a warning in such cases.


 Perhaps the MPIR developers will fix this upstream in a quick 2.1.4, such
 that it will be a non-issue soon, since we're going to upgrade MPIR
 anyway.

 Nevertheless, feel free to send them a patch fixing their
 autotools/`configure`. ;-)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10188#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to