#7513: Update Mercurial to 1.6.4
------------------------------+---------------------------------------------
Reporter: mhansen | Owner: tbd
Type: task | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: packages | Keywords: hg spkg
Author: Jeroen Demeyer | Upstream: N/A
Reviewer: Leif Leonhardy | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by jdemeyer):
Replying to [comment:6 leif]:
> I originally wanted to give it immediately a positive review, though
`patches/posix.py.patch` (which is redundant and for reference only) had
not been updated, but just the line numbers changed. (I haven't updated it
either.)
Since the patch still applies perfectly fine, I don't think it is a
problem that the line numbers don't match (note that I created
{{{patches/posix.py}}} from {{{patches/posix.py.patch}}}, not the other
way around).
> Jeroen's changes look fine, except `spkg-install` still tried to copy an
obsolete, now removed patch (to `setup.py`).
Thanks for spotting this.
> Then I took a closer look at the rest (including `SPKG.txt`), which
ended up in my reviewer patch.
>
> Jeroen, if you agree with my changes, please merge them into the spkg,
and I can give it positive review. ;-)
Thanks for looking more carefully at this, I just wanted a new spkg
quickly :-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7513#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
