#8442: Lie Methods and Related Combinatorics (tutorial)
--------------------------------------------+-------------------------------
   Reporter:  bump                          |       Owner:  bump      
       Type:  enhancement                   |      Status:  needs_work
   Priority:  major                         |   Milestone:  sage-4.6.1
  Component:  documentation                 |    Keywords:            
     Author:  Daniel Bump                   |    Upstream:  N/A       
   Reviewer:  Minh Van Nguyen, Mark Jordan  |      Merged:            
Work_issues:                                |  
--------------------------------------------+-------------------------------
Changes (by jhpalmieri):

  * status:  needs_review => needs_work


Comment:

 This looks like an amazing document to include with Sage.  Thanks for
 working on it.

 First, all doctests pass for me.

 I get three warnings when building the docs, two of which anyone can fix:
 {{{
 
/Applications/sage/devel/sage/doc/en/thematic_tutorials/lie/weyl_character_ring.rst:397:
 (WARNING/2) Title underline too short.

 Integration
 -------
 
/Applications/sage/devel/sage/doc/en/thematic_tutorials/lie/weyl_character_ring.rst:397:
 (WARNING/2) Title underline too short.

 Integration
 -------
 }}}
 The third one I think Dan has to do:
 {{{
 /Applications/sage/devel/sage/doc/en/thematic_tutorials/lie/weyl_groups.rst::
 WARNING: citation not found: BumpNakasuji2010
 }}}

 A few questions and comments about the text: first, the style in the Sage
 documentation is to use {{{\Bold{C}}}} for the complex numbers, and
 similarly for R and Q.  This is more of an issue for docstrings for
 methods, functions, etc., but you might consider changing it.

 In introduction.rst,
 {{{
 For example, we could take `G = SU(n)`,
 `\mathfrak{g} = \mathfrak{sl}(n, \mathbb{R})`,
 `\mathfrak{g}_{\mathbb{C}} = \mathfrak{sl}(n, \mathbb{C})` and
 `G = SL(n, \mathbb{C})`.
 }}}
 Should the last "G" be "G_{\mathbb{C}}" (or "G_{\Bold{C}}")?

 In lie_basics.rst, on line 141: {{{However Parabolic subgroups do not
 exist for compact Lie groups.}}}  Don't capitalize "Parabolic".

 On line 150:
 {{{
 Such a type is implemented in Sage as a pair ``[`X`,r]``
 }}}
 I would use plain quotes around the X, not backquotes: {{{``['X',r]``}}}

 A few lines later:
 {{{
 The exceptional types are::

     ['G',2],  ['F',4],  ['E',6], ['E',7] or ['E',8].
 }}}
 The indented block is verbatim text, so spacing matters.  The
 inconsistency between double-spacing and single-spacing looks odd to me,
 and I would just put single spaces after all of the commas.

 weyl_character_ring.rst, line 239, {{{with Cartan type `['B',r]`}}}: I
 would use double back quotes here instead of single ones.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8442#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to