#10238: Containment checks are wrong for empty polyhedra
----------------------------------+-----------------------------------------
   Reporter:  novoselt            |       Owner:  mhampton  
       Type:  defect              |      Status:  needs_info
   Priority:  major               |   Milestone:  sage-4.6.1
  Component:  geometry            |    Keywords:            
     Author:  Volker Braun        |    Upstream:  N/A       
   Reviewer:  Andrey Novoseltsev  |      Merged:            
Work_issues:                      |  
----------------------------------+-----------------------------------------
Changes (by novoselt):

  * status:  needs_review => needs_info


Comment:

 Patch order issues:
 {{{
 applying trac_10238_containment_check_for_empty_polyhedra.patch
 patching file sage/geometry/polyhedra.py
 Hunk #8 succeeded at 4208 with fuzz 2 (offset 446 lines).
 now at: trac_10238_containment_check_for_empty_polyhedra.patch
 }}}
 (Tested on top of face lattice.)

 I am fine with this version, but just to make sure: you really want to
 start the line with "+" if there are no variables and have space between
 the sign and the coefficient only if there are variables?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10238#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to