#8898: some files in sage-4.4.{0,1} have dos line ending instead of a unix line
ending
-------------------------------+--------------------------------------------
   Reporter:  fbissey          |       Owner:  jason       
       Type:  defect           |      Status:  needs_review
   Priority:  trivial          |   Milestone:  sage-4.6.1  
  Component:  misc             |    Keywords:              
     Author:  Minh Van Nguyen  |    Upstream:  N/A         
   Reviewer:                   |      Merged:              
Work_issues:                   |  
-------------------------------+--------------------------------------------

Old description:

> the following 4 files in the sage spkg have dos line ending rather than
> unix ones:
>
>  * sage/libs/mpmath/ext_impl.pxd
>  * sage/libs/mpmath/ext_main.pyx
>  * sage/libs/mpmath/ext_main.pxd
>  * sage/libs/mpmath/ext_libmp.pyx
>
> I found about this while trying to build sage with python-2.6.5
> which absolutely refused to parse these files as is.
> Not sure how to submit a patch for line endings.

New description:

 the following 4 files in the sage spkg have dos line ending rather than
 unix ones:

  * sage/libs/mpmath/ext_impl.pxd
  * sage/libs/mpmath/ext_main.pyx
  * sage/libs/mpmath/ext_main.pxd
  * sage/libs/mpmath/ext_libmp.pyx

 I found about this while trying to build sage with python-2.6.5
 which absolutely refused to parse these files as is.
 Not sure how to submit a patch for line endings.

 '''Apply:'''

  1. [attachment:trac-8898_unix-endlines.patch]

--

Comment(by mvngu):

 Here are some problems with [attachment:trac_8898-unix-endlines.2.patch]:

  * It fails to apply on Sage 4.6.1.alpha0; I got the following failure:
  {{{
 [mv...@sage sage-main]$ pwd
 /dev/shm/mvngu/sage-4.6.1.alpha0/devel/sage-main
 [mv...@sage sage-main]$ hg qimport http://trac.sagemath.org/sage_trac/raw-
 attachment/ticket/8898/trac_8898-unix-endlines.2.patch && hg qpush
 adding trac_8898-unix-endlines.2.patch to series file
 applying trac_8898-unix-endlines.2.patch
 patching file sage/libs/mpmath/ext_main.pyx
 Hunk #1 FAILED at 0
 1 out of 1 hunks FAILED -- saving rejects to file
 sage/libs/mpmath/ext_main.pyx.rej
 patch failed, unable to continue (try -v)
 patch failed, rejects left in working dir
 errors during apply, please fix and refresh trac_8898-unix-
 endlines.2.patch
  }}}

  * The attachment [attachment:trac_8898-unix-endlines.2.patch] doesn't
 convert the file `sage/logic/booleval.py` to use Unix line ending.

 My rebased patch should take care of the above issues for Sage
 4.6.1.alpha0. See the ticket description for which patch to apply.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8898#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to