#8674: Comparison of combinatorial class of words with word paths is broken
---------------------------------------+------------------------------------
Reporter: slabbe | Owner: slabbe
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.6.1
Component: combinatorics | Keywords:
Author: Sébastien Labbé | Upstream: N/A
Reviewer: Alexandre Blondin Massé | Merged:
Work_issues: |
---------------------------------------+------------------------------------
Changes (by abmasse):
* status: needs_review => needs_work
Comment:
Already 7 months !!!! Sorry again for the delay...
I retested on sage-4.6 the two patches but I get a bunch of doctest
failures. Were they already there or do they come from the fact that the
patches were submitted seven months ago?
{{{
labo [~/Applications/sage/devel/sage-t8674/sage/combinat/words]
$ sage -t *
sage -t "devel/sage-t8674/sage/combinat/words/__init__.py"
[0.1 s]
sage -t "devel/sage-t8674/sage/combinat/words/abstract_word.py"
[2.6 s]
sage -t "devel/sage-t8674/sage/combinat/words/all.py"
[0.1 s]
sage -t "devel/sage-t8674/sage/combinat/words/alphabet.py"
[2.4 s]
sage -t "devel/sage-t8674/sage/combinat/words/finite_word.py"
[13.2 s]
sage -t "devel/sage-t8674/sage/combinat/words/infinite_word.py"
[2.4 s]
sage -t "devel/sage-t8674/sage/combinat/words/morphism.py"
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/morphism.py",
line 907:
sage: m.is_endomorphism()
Expected:
True
Got:
False
**********************************************************************
1 items had failures:
1 of 11 in __main__.example_17
***Test Failed*** 1 failures.
For whitespace errors, see the file
/Users/alexandre/.sage//tmp/.doctest_morphism.py
[2.9 s]
sage -t "devel/sage-t8674/sage/combinat/words/nfactor_enumerable_word.py"
[5.5 s]
sage -t "devel/sage-t8674/sage/combinat/words/paths.py"
[7.5 s]
sage -t "devel/sage-t8674/sage/combinat/words/shuffle_product.py"
[2.5 s]
sage -t "devel/sage-t8674/sage/combinat/words/suffix_trees.py"
[5.2 s]
sage -t "devel/sage-t8674/sage/combinat/words/utils.py"
[2.4 s]
sage -t "devel/sage-t8674/sage/combinat/words/word.py"
[2.5 s]
sage -t "devel/sage-t8674/sage/combinat/words/word_content.py"
[2.5 s]
sage -t "devel/sage-t8674/sage/combinat/words/word_datatypes.pyx"
[2.5 s]
sage -t "devel/sage-t8674/sage/combinat/words/word_generators.py"
[7.9 s]
sage -t "devel/sage-t8674/sage/combinat/words/word_infinite_datatypes.py"
[2.5 s]
sage -t "devel/sage-t8674/sage/combinat/words/word_options.py"
[2.6 s]
sage -t "devel/sage-t8674/sage/combinat/words/words.py"
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/words.py",
line 690:
sage: WordPaths('abcd') != Words('abcd')
Expected:
False
Got:
True
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/words.py",
line 692:
sage: Words('abcd') != WordPaths('abcd')
Expected:
False
Got:
True
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/words.py",
line 925:
sage: WordPaths('abcd') <= Words('abcd')
Expected:
True
Got:
False
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/words.py",
line 952:
sage: Words('abcd') >= WordPaths('abcd')
Expected:
True
Got:
False
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/words.py",
line 437:
sage: type(z)
Expected:
<class 'sage.combinat.words.word.FiniteWord_list'>
Got:
<class 'sage.combinat.words.word.FiniteWord_str'>
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/words.py",
line 661:
sage: WordPaths('abcd') == Words('abcd')
Expected:
True
Got:
False
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/words.py",
line 663:
sage: Words('abcd') == WordPaths('abcd')
Expected:
True
Got:
False
**********************************************************************
File
"/Users/alexandre/Applications/sage/devel/sage-t8674/sage/combinat/words/words.py",
line 667:
sage: WordPaths('bacd') == WordPaths('abcd')
Expected:
False
Got:
True
**********************************************************************
5 items had failures:
2 of 7 in __main__.example_10
1 of 7 in __main__.example_22
1 of 7 in __main__.example_23
1 of 63 in __main__.example_5
3 of 12 in __main__.example_9
***Test Failed*** 8 failures.
For whitespace errors, see the file
/Users/alexandre/.sage//tmp/.doctest_words.py
[2.9 s]
----------------------------------------------------------------------
The following tests failed:
sage -t "devel/sage-t8674/sage/combinat/words/morphism.py"
sage -t "devel/sage-t8674/sage/combinat/words/words.py"
Total time for all tests: 70.4 seconds
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8674#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
