#7983: Notion of descent/major index in tableau.py is not mathematically 
standard
-----------------------------+----------------------------------------------
   Reporter:  jbandlow       |       Owner:  sage-combinat
       Type:  defect         |      Status:  needs_work   
   Priority:  major          |   Milestone:               
  Component:  combinatorics  |    Keywords:               
     Author:                 |    Upstream:  N/A          
   Reviewer:  jbandlow       |      Merged:               
Work_issues:                 |  
-----------------------------+----------------------------------------------

Comment(by arattan):

 Replying to [comment:2 jbandlow]:
 > Thanks for the patch!  While I don't have time for a full review now,
 the main issue with this patch is going to be backward compatibility.  I'm
 pretty sure that the Macdonald polynomial code uses these functions, so
 sage --testall will probably fail after applying your patch.  That part
 will not be too hard to fix, but the bigger problem is for people who have
 sage code on their own machine.  When people upgrade sage and this change
 is included (without them necessarily knowing about it) this change could
 make their code behave in slightly wrong ways that are not obvious.  We
 really try to avoid that.
 >
 > So I think the thing to do is to deprecate 'descents' and 'major_index'
 (look up deprecation in the developers guide), use 'i_descents' and
 'i_major_index' for the existing statistics (as you have done) and give
 the classical statistics some new name. (Suggestions welcome!)

 Yes, I thought this would be an issue.  I actually made the patch a while
 ago but thought that precisely your objection would be raised.  Anyways, I
 decided to send it in and see what would happen.  It sounds like you have
 a good solution.

 About a new name:  is "Major_Index" a bad idea?  I don't know about sage's
 naming conventions.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7983#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to