#10318: Change CompositConstructionFunctor to CompositeConstructionFunctor
----------------------------+-----------------------------------------------
Reporter: cremona | Owner: nthiery
Type: defect | Status: needs_review
Priority: trivial | Milestone: sage-4.6.1
Component: categories | Keywords:
Author: John Cremona | Upstream: N/A
Reviewer: David Kirkby | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by drkirkby):
* reviewer: => David Kirkby
Comment:
I'm a bit puzzled why the need for two patches. Is the combined patch one
in which could be used instead of the patch on #8807?
I have no problems giving the small patch a positive reivew. I guess its
up to the release manager how best to handle this - whether #8807 is
applied first, and then your simple patch, or just your combined patch.
I would have thought the best way to handle this was to just have the
simple patch, and make it conditional on #8807 being applied first.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10318#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
