#10183: long doctests wrongly tagged "# long" instead of "#long time"
---------------------------------------------+------------------------------
   Reporter:  cremona                        |       Owner:  mvngu           
       Type:  defect                         |      Status:  positive_review 
   Priority:  minor                          |   Milestone:  sage-4.6.1      
  Component:  doctest                        |    Keywords:  doctest long tag
     Author:  Damek Davis, Benjamin Jones    |    Upstream:  N/A             
   Reviewer:  John Cremona, Minh Van Nguyen  |      Merged:                  
Work_issues:                                 |  
---------------------------------------------+------------------------------
Changes (by newvalueoldvalue):

  * status:  needs_review => positive_review
  * reviewer:  => John Cremona, Minh Van Nguyen
  * author:  => Damek Davis, Benjamin Jones


Old description:

> In several places, long doctests are incorrectly tagged "# long" instead
> of "# long time", thus mistakenly preventing them from being omitted when
> "-long" is not included on the command line.
>
> On of these is at #10182.  The rest are:
> {{{
> combinat/sf/sfa.py:            sage: a.itensor(a) #long
> graphs/graph_generators.py:            sage: G.show() # long
> graphs/graph.py:            sage: K5_minor =
> g.minor(graphs.CompleteGraph(5))                    # long
> graphs/graph.py:            sage: K33_minor =
> g.minor(graphs.CompleteBipartiteGraph(3,3))        # long
> lfunctions/sympow.py:            sage:
> sympow.analytic_rank(EllipticCurve([0, 0, 1, -79, 342]))  # long
> lfunctions/sympow.py:            sage:
> sympow.analytic_rank(EllipticCurve([1, 1, 0, -2582, 48720]))  # long
> lfunctions/sympow.py:            sage:
> sympow.analytic_rank(EllipticCurve([0, 0, 0, -10012, 346900]))  # long
> lfunctions/lcalc.py:            sage: lcalc.zeros(4)
>        # long
> lfunctions/lcalc.py:            sage: lcalc.zeros(5, L='--tau')
>        # long
> lfunctions/lcalc.py:            sage: lcalc.zeros(3,
> EllipticCurve('37a'))     # long
> modules/fg_pid/fgp_module.py:        sage: set_random_seed(s); v =
> [fgp.test_morphism_0(4) for _ in range(50)]    # long
> plot/plot.py:            sage: sum([plot(z*sin(x), 0, 10).plot3d(z)
> for z in range(6)]) #long
> plot/plot.py:            sage: p.show(gridlines=( [-3,-2.75,..,3],
> xrange(-1,5,2) )) #long
> rings/qqbar.py:            sage: a.exactify(); a #long
> schemes/elliptic_curves/heegner.py:        sage:
> kolyvagin_reduction_data(E,3)              # long
> schemes/elliptic_curves/ell_rational_field.py:            sage: E =
> EllipticCurve([1, -1, 0, -751055859, -7922219731979])     # long (0.6
> seconds)
> schemes/elliptic_curves/ell_rational_field.py:            sage:
> EllipticCurve('681b').three_selmer_rank(algorithm='Heuristic')   #
> long (10 seconds); optional - magma
> schemes/elliptic_curves/lseries_ell.py:            sage:
> E.lseries().zeros_in_interval(6, 10, 0.1)      # long
> schemes/elliptic_curves/lseries_ell.py:            sage:
> E.lseries().twist_zeros(3, -4, -3)         # long
> schemes/generic/fano_toric_variety.py:    sage: p4318 =
> ReflexivePolytope(3, 4318)  # long
> schemes/generic/fano_toric_variety.py:    sage: FTV =
> CPRFanoToricVariety(Delta_polar=p4318)  # long
> schemes/generic/fano_toric_variety.py:    sage:
> FTV.anticanonical_hypersurface()  # long
> }}}
> (This list is not guaranteed to be complete, and may contain lines which
> are fine).

New description:

 In several places, long doctests are incorrectly tagged "# long" instead
 of "# long time", thus mistakenly preventing them from being omitted when
 "-long" is not included on the command line.

 On of these is at #10182.  The rest are:
 {{{
 combinat/sf/sfa.py:            sage: a.itensor(a) #long
 graphs/graph_generators.py:            sage: G.show() # long
 graphs/graph.py:            sage: K5_minor =
 g.minor(graphs.CompleteGraph(5))                    # long
 graphs/graph.py:            sage: K33_minor =
 g.minor(graphs.CompleteBipartiteGraph(3,3))        # long
 lfunctions/sympow.py:            sage:
 sympow.analytic_rank(EllipticCurve([0, 0, 1, -79, 342]))  # long
 lfunctions/sympow.py:            sage:
 sympow.analytic_rank(EllipticCurve([1, 1, 0, -2582, 48720]))  # long
 lfunctions/sympow.py:            sage:
 sympow.analytic_rank(EllipticCurve([0, 0, 0, -10012, 346900]))  # long
 lfunctions/lcalc.py:            sage: lcalc.zeros(4)
        # long
 lfunctions/lcalc.py:            sage: lcalc.zeros(5, L='--tau')
        # long
 lfunctions/lcalc.py:            sage: lcalc.zeros(3,
 EllipticCurve('37a'))     # long
 modules/fg_pid/fgp_module.py:        sage: set_random_seed(s); v =
 [fgp.test_morphism_0(4) for _ in range(50)]    # long
 plot/plot.py:            sage: sum([plot(z*sin(x), 0, 10).plot3d(z)
 for z in range(6)]) #long
 plot/plot.py:            sage: p.show(gridlines=( [-3,-2.75,..,3],
 xrange(-1,5,2) )) #long
 rings/qqbar.py:            sage: a.exactify(); a #long
 schemes/elliptic_curves/heegner.py:        sage:
 kolyvagin_reduction_data(E,3)              # long
 schemes/elliptic_curves/ell_rational_field.py:            sage: E =
 EllipticCurve([1, -1, 0, -751055859, -7922219731979])     # long (0.6
 seconds)
 schemes/elliptic_curves/ell_rational_field.py:            sage:
 EllipticCurve('681b').three_selmer_rank(algorithm='Heuristic')   #
 long (10 seconds); optional - magma
 schemes/elliptic_curves/lseries_ell.py:            sage:
 E.lseries().zeros_in_interval(6, 10, 0.1)      # long
 schemes/elliptic_curves/lseries_ell.py:            sage:
 E.lseries().twist_zeros(3, -4, -3)         # long
 schemes/generic/fano_toric_variety.py:    sage: p4318 =
 ReflexivePolytope(3, 4318)  # long
 schemes/generic/fano_toric_variety.py:    sage: FTV =
 CPRFanoToricVariety(Delta_polar=p4318)  # long
 schemes/generic/fano_toric_variety.py:    sage:
 FTV.anticanonical_hypersurface()  # long
 }}}
 (This list is not guaranteed to be complete, and may contain lines which
 are fine).

 '''Apply:'''

  1. [attachment:trac_10183_long_to_long_time.patch]
  1. [attachment:trac_10183_additional_long_time_tags.patch]

--

Comment:

 Both patches look good to me. See the ticket description for instructions
 on which tickets to apply and in which order.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10183#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to