#9910: Longest path
----------------------------------------------+-----------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: graph theory | Keywords:
Author: Nathann Cohen | Upstream: N/A
Reviewer: Robert Miller, Minh Van Nguyen | Merged:
Work_issues: |
----------------------------------------------+-----------------------------
Comment(by ncohen):
Hello !!!
Here is a patch to import on top of your, to fix the documentation. These
options are just a way for the user to compute the "longest path leaving
from s", or the "longest path ending in t", or the "longest s-t-path"
About the if/else, I knew it was not useful but I let it stay anyway
thinking it would be easier to understand the code. When I look at it from
afar, I like to see a If/Else with return lines at the end of both, which
ensures the method ends because of this part of the code (and I like to
preserve symmetry when there is no reason not to `^^;`). That's just me,
if you think it's better without the "else", then let it be.
I am really sorry you had to waste time fixing my spaces and long lines. I
know I never paid attention to spaces, but I will from now on, and I
thought I was wary enough of long lines, which is clearly untrue. I also
thought I had learned not to write ``x == None`` too... `:-/`
Here is the slight fix in the documentation you asked. If it suits you,
the ticket is good to go.
Thank you for your precious help, once again !
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9910#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
