#10326: Various clean-up in local/bin/sage-sage
------------------------------+---------------------------------------------
Reporter: jdemeyer | Owner: jason
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.6.1
Component: misc | Keywords: scripts sage-sage
Author: Jeroen Demeyer | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by rbeezer):
Reorganization of -help and -advanced looks real good! I prefer the
topical organization versus the alphabetical listing. Some comments,
questions, suggestions to consider.
1. The change in the banner listing means the notice about being a
"prerelease" version is no longer included in the help output. Was this
intended? Unpatched:
{{{
----------------------------------------------------------------------
| Sage Version 4.6.1.alpha2, Release Date: 2010-11-21 |
* Warning: this is a prerelease version, and it may be unstable. *
----------------------------------------------------------------------
}}}
Patched:
{{{
----------------------------------------------------------------------
| Sage Version 4.6.1.alpha2, Release Date: 2010-11-21 |
----------------------------------------------------------------------
}}}
2. On help for running the notebook, I would use "for" rather than "to"
{{{
(options are the same as to the notebook command in Sage)
}}}
3. There are tests to see if various packages/add-ons are installed and
no help is given of they are not available. I think I would prefer to see
'''all''' available options and then a message saying when an add-on is
not avaailable. This way people could see what is possible and install
the add-ons if they want them. So, for example, suppose `kash` is not
installed, then maybe output could be something like:
{{{
-kash [...] -- run Sage's Kash with given arguments
(not installed currently, run sage -i kash)
}}}
4. Applied in local/bin on 4.6.1.alpha2 and got 1 failure. Didn't really
investigate any further. And I just now see I failed to notice the
dependency on #10300 (and precursors), so likely that is the cause.
{{{
r...@wave:/sage/dev/local/bin$ hg qimport -P
http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/10326/10326_cleanup_sage_sage.patch
adding 10326_cleanup_sage_sage.patch to series file
applying 10326_cleanup_sage_sage.patch
patching file sage-sage
Hunk #9 FAILED at 498
1 out of 18 hunks FAILED -- saving rejects to file sage-sage.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 10326_cleanup_sage_sage.patch
r...@wave:/sage/dev/local/bin$ cat sage-sage.rej
--- sage-sage
+++ sage-sage
@@ -421,15 +499,15 @@
SHELL_OPTS=" -f -d"
;;
*)
- echo "Unknown shell: $SHELL!"
- echo "Exiting Sage."
+ echo >&2 "Unknown shell: $SHELL!"
+ echo >&2 "Exiting Sage."
exit 1
esac
$SHELL_NAME $SHELL_OPTS "$@"
status=$?
- echo Exited Sage subshell.
+ echo "Exited Sage subshell."
exit $status
fi
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10326#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
