#7644: generic power series reversion
-----------------------------+----------------------------------------------
   Reporter:  was            |       Owner:  AlexGhitza         
       Type:  enhancement    |      Status:  needs_review       
   Priority:  major          |   Milestone:  sage-4.6.1         
  Component:  algebra        |    Keywords:  lagrange, reversion
     Author:  Niles Johnson  |    Upstream:  N/A                
   Reviewer:                 |      Merged:                     
Work_issues:                 |  
-----------------------------+----------------------------------------------

Comment(by fwclarke):

 This is looking good.  Some comments on the docstring:

 {{{
 If f has infinite precision, then the precision
 of the reversion defaults to the default precision of
 ``f.parent()``.
 }}}
 should say "unless precision is set", or words to that effect.

 The remark a few lines later that

 {{{
 self must have finite precision (i.e. this cannot be done
 for polynomials).
 }}}
 is no longer appropriate.  Nor is

 {{{
 Under the current implementation, the leading
 coefficient must be a unit in the base ring, and the base ring must
 have characteristic zero.
 }}}
 I'm not sure that

 {{{
 In positive characteristic, attempt first to lift to characteristic
 zero and perform the reversion there:
 }}}
 is in the right place; it's really to do with the algorithm.  Perhaps
 better to say here that the function can handle some base rings of non-
 zero characteristic.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7644#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to