#9423: Gap interface for number fields
-----------------------------------------+----------------------------------
   Reporter:  SimonKing                  |       Owner:  was                    
   
       Type:  defect                     |      Status:  needs_review           
   
   Priority:  major                      |   Milestone:  sage-4.6.1             
   
  Component:  interfaces                 |    Keywords:  gap interface number 
field
     Author:  Simon King                 |    Upstream:  N/A                    
   
   Reviewer:  Luis Felipe Tabera Alonso  |      Merged:                         
   
Work_issues:                             |  
-----------------------------------------+----------------------------------
Changes (by lftabera):

  * reviewer:  => Luis Felipe Tabera Alonso


Comment:

 The code corrects a couple of bugs in the gap interface of number fields.
 Since ! cannot be part of the name of a generator of a number field, then
 eliminating "!" from the gap representation is correct.

 The solution to the "E" variable problem is correct, althought there
 should be a more system-wide solution to this kind of problems.

 I will not give it a positive review until #5618 is also ready to merge,
 since this patch eliminates a doctest that after #5618 will be obsolete.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9423#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to