#10458: Doctest framework fails to parse multiline input pasted from sage
interactive prompt
---------------------------+------------------------------------------------
Reporter: kini | Owner: mvngu
Type: defect | Status: new
Priority: major | Milestone:
Component: doctest | Keywords: doctest, continuation, multiline
input, interactive prompt
Author: Keshav Kini | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Comment(by leif):
Replying to [comment:10 kini]:
> Replying to [comment:8 leif]:
> > I mean add the space to ''all'' prompt patterns to match (and of
course their substitutes), e.g. line 485 (it's in the comment, but not the
code) and line 613 (also in the comment on line 251).
> >
>
> Ah, I see. Yes, I left those alone because changing them would change
the behavior of the doctesting framework for docstrings containing lines
like "sage:dostuff()" or "...dostuff()". Arguably the doctest framework
''shouldn't'' be allowing lines like that anyway, but at the moment it
does...
Well, that's just another bug (we should fix here, too).
[[BR]]
> By the way, when changing my patch submission should I be uploading
further patch files to layer on top of the one I've got here, or replacing
this patch with new patches which diff to 4.6?
Depends on the changes. Unfortunately, ordinary trac users cannot
''delete'' (or rename) attachments, not even their own.
So you could upload a new patch with `trac_XXXXX-` in the filename, and
let someone else delete the old one.
In general, it's ok to replace your patch with an updated one (sometimes
better than having `-v2` etc.); in case you make further changes ''rather
unrelated'' to the previous ones, it's usually better to attach a second
patch which is ''based on'' your previous one. (The attachment comment
should then say "''Apply on top of ...''".)
Also, patches should be based on the most recent ''developer'' version of
Sage, i.e. the current alpha or rc. Unless there are merge conflicts
(because someone else has changed code near to your changes), it's ok to
have it based on some previous official release, too. (But you should
always check your patch applies clean to the latest developer release.)
The attachment comment should contain the name of the repository to which
to apply the patch (the "default" is the Sage library), in this case
"Scripts repo", and usually also mentions on what Sage release it is
based, since it is not unusual new releases get out before a ticket gets
merged.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10458#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
