#3537: [with patch] sage-env should set RM="rm -f"
----------------------+-----------------------------------------------------
Reporter: gfurnish | Owner: gfurnish
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6.2
Component: build | Resolution:
Keywords: | Author: gfurnish
Upstream: N/A | Reviewer:
Merged: | Work_issues:
----------------------+-----------------------------------------------------
Changes (by leif):
* cc: drkirkby, jdemeyer (added)
Comment:
Replying to [comment:5 vbraun]:
> I'm reopening this bug since people keep tripping over this issue. We
need to fix this or we'll end up with every spkg working around the
`RM=rm` issue.
Well, is this a bug?
> More and more packages will fail because of this issue as soon as
upsteam re-runs autotools...
That's IMHO a problem of autotools. `$RM` is in general not supposed to
''not return an error'' on non-existing files; if autotools were a bit
smarter, they would just add `-f` or whatever might be appropriate. If
they redefine the meaning of `RM`, that's not Sage's problem in the first
place; of course spkg maintainers would have to `unset RM` for upstream
packages using (newer) autotools.
> I'd be happy to give this a positive review. Maybe mabshoff can
reconsider his objections?
Michael has quit a while ago, though he perhaps still reads trac
notifications... ;-)
Note that redefining `RM` in `sage-env` could actually break other parts
of Sage, not necessarily limited to spkgs, since e.g. removing a file
which is expected to exist, but doesn't, without raising an error might
hide other errors and cause arbitrary behavior.
Also, as Michael said, changing the default value in `sage-env` doesn't
help if `RM` was already defined (intentionally or not) by the user, so
w.r.t. autotools really ''won't fix''. We have to `unset RM` (or add an
appropriate flag to force deletion if it's not already contained) in
`spkg-install`s of such packages anyway to be safe.
I think we should prominently document this issue, and close this ticket
again.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3537#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
