#10496: The default call method of maps does not do as promised by the
documentation
--------------------------+-------------------------------------------------
   Reporter:  SimonKing   |       Owner:  robertwb        
       Type:  defect      |      Status:  needs_work      
   Priority:  major       |   Milestone:  sage-4.6.2      
  Component:  coercion    |    Keywords:  generic call map
     Author:  Simon King  |    Upstream:  N/A             
   Reviewer:  David Roe   |      Merged:                  
Work_issues:              |  
--------------------------+-------------------------------------------------
Changes (by roed):

  * status:  needs_review => needs_work
  * reviewer:  => David Roe


Comment:

 I approve of the design and goals, but I'm worried about the
 implementation speed.  The current implementation does not introduce much
 overhead over `_call_`, but
 {{{
 if not self._domain.has_coerce_map_from(parent_c(x)):
     if hasattr(self,'pushforward'):
 }}}
 are both pretty costly calls.  I think you need to add some fast pathways
 for common cases, such as `x` actually lying in the domain.

 Similarly, use `PY_TYPE_CHECK` in cython files, rather than `isinstance`.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10496#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to