#10339: Simplify spkg/pipestatus
------------------------------+---------------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.6.1
Component: scripts | Keywords: pipestatus Makefile
Author: Jeroen Demeyer | Upstream: N/A
Reviewer: Leif Leonhardy | Merged: sage-4.6.1.rc0
Work_issues: |
------------------------------+---------------------------------------------
Changes (by leif):
* status: needs_review => positive_review
Comment:
To bring this (at least the ticket) to an end, '''positive review''' from
me (as I am a co-author / have suggested most of the current changes ;-)
).
It's also clearly better to use an "unambiguous" call of `pipestatus` in
the (top-level) `Makefile`. We could still add a note to `pipestatus`'
usage message that it behaves as if
{{{
#!sh
set -o pipefail; CMD1 | CMD2
}}}
was issued at the shell prompt, as John suggested IIRC.
Until we drop support for Bashs < 3.0 ...
(and/or ''generate'' the Makefiles, creating "customized" versions
depending on the version of the shell found.)
In any case, it's better to not mess around with file descriptors that
might already be used (i.e. use Bash's `PIPESTATUS` array instead, since
we rely on `bash` anyway).
----
Because `bash` '''is''' in fact a prerequisite for Sage, I still see no
reason for not making a ''contemporary'' version of it a requirement. If
people lacking one are unable to build/install it themselves from the GNU
tarball, they can still install pre-built binaries, which AFAIK need not
even be provided by Sage as there are already such packages available
elsewhere.
I wouldn't consider a shell a battery either, and we ''do'' care less
about older / out-dated releases of ''other'' operating systems.
----
The ticket's description should perhaps be updated to reflect the outcome.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10339#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
