#9960: require SAGE_CHECK to be "yes"
---------------------------------------------+------------------------------
Reporter: jhpalmieri | Owner: was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: user interface | Keywords:
Author: John Palmieri, Leif Leonhardy | Upstream: N/A
Reviewer: Leif Leonhardy | Merged:
Work_issues: |
---------------------------------------------+------------------------------
Changes (by newvalueoldvalue):
* status: needs_work => needs_review
* reviewer: => Leif Leonhardy
* work_issues: Rebase reviewer patch. =>
* author: John Palmieri => John Palmieri, Leif Leonhardy
Comment:
I've now also attached a rebased version of my "reviewer" patch, with some
more changes:
''Besides cosmetic changes (formatting, tabs, some messages), I've only''
* ''added lots of comments (including TODOs/notes on future changes),''
* ''quoted all necessary environment variables,''
* ''fixed a bug which caused a successful test suite run never getting
logged (to 'spkg/installed/<package-name>').''
''So there are (still) lots of things to do, but on another ticket.''
----
I can of course only review John's changes (which I already did, leading
to my reviewer patch, so I'm in principle ok with his changes, although I
haven't tested them recently); so someone else has to review mine. (I'm
going to test them with 4.6.1.rc0 again though I don't expect new,
undesired behavior.)
Additional changes (other than fixes of possible mistakes introduced here)
should IMHO be made on follow-up tickets; as mentioned in the commit
message (and comments in `sage-spkg`), there are quite a lot things to get
fixed or improved.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:43>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
