#10479: Nef-partitions rewrite
-----------------------------------+----------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6.2
Component: geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: documentation build |
-----------------------------------+----------------------------------------
Changes (by vbraun):
* status: needs_review => needs_work
* reviewer: => Volker Braun
Comment:
In principle I'm happy with the implementation. Just two minor details:
About the four equations, I think it would be better to avoid explicit
spacing. Whats 1ex in a web browser, in a terminal??. You can just split
it into two equations and say something like nef partition blah (equation)
is dual to the nef partition (equation).
My other suggestion would be to explain the INPUT section of the
`nef_partition()` method in more detail. I realize that you are just
refactoring that part, but it would be very helpful if you would spell out
what the options do. Whats a symmetric partition?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10479#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
