#8216: Make David Perkinson's sandpile 2.2 module an experimental (at least)
package
---------------------------------+------------------------------------------
Reporter: mhampton | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: optional packages | Keywords: sandpile
Author: | Upstream: N/A
Reviewer: David Kirkby | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Comment(by drkirkby):
There's no
{{{
== Special Update/Build Instructions ==
}}}
section in the spkg-install file. It would be worth adding it. There's no
spkg-check file. Are there any self-tests?
This bit of code is a bit dubious. First it's not a good idea to test on
an empty string (though I'm aware lots of bits of Sage do it, but also
there's an unnecessary semi-colon.
{{{
if [ "$SAGE_LOCAL" = "" ]; then
echo "SAGE_LOCAL undefined ... exiting";
echo "Maybe run 'sage -sh'?"
exit 1
fi
}}}
Better would be
{{{
if [ "x$SAGE_LOCAL" = x ]; then
echo "SAGE_LOCAL undefined ... exiting"
echo "Maybe run 'sage -sh'?"
exit 1
fi
}}}
That semi-colon obviously got put in one file at one point, and has been
copy/pasted to lots of spkg-install files, but it serves no useful
function.
I believe an earlier version of this did not work on Solaris. Has anyone
checked if this one does work? I don't see any comments to suggest the
issue was resolved.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8216#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
