#10473: Wrong docs of _lmul_ and _rmul_ in the polynomial module
--------------------------------+-------------------------------------------
Reporter: klee | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: trivial | Milestone: sage-4.6.1
Component: basic arithmetic | Keywords:
Author: Kwankyu Lee | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Comment(by spancratz):
Thank you for the quick reply.
Unfortunately, the patch still does not apply cleanly to 4.6.1.rc0. It's
the second hunk of the patch that fails, i.e., the following
{{{
--- polynomial_rational_flint.pyx
+++ polynomial_rational_flint.pyx
@@ -923,14 +923,14 @@
"""
cdef Polynomial_rational_flint res = self._new()
cdef bint do_sig = _do_sig(self.__poly)
-
+
if do_sig: _sig_on
fmpq_poly_scalar_mul_mpq(res.__poly, self.__poly, \
- (<Rational> right).value)
+ (<Rational> left).value)
if do_sig: _sig_off
return res
- cpdef ModuleElement _rmul_(self, RingElement right):
+ cpdef ModuleElement _lmul_(self, RingElement right):
r"""
Returns self * right, where right is a rational number.
}}}
I am not quite sure why this is; perhaps you accidentally did not upload
the updated patch?
Feel free to try again (and I'll check and review it). Alternatively, I
am also happy to fix this myself; let me know what you prefer.
Best wishes,
Sebastian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10473#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
