#7981: animate ignores options to show that are passed up from the plot command
----------------------------------------------------------------+-----------
Reporter: jason | Owner:
novoselt
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-4.6.2
Component: graphics | Keywords:
Author: Jason Grout, Andrey Novoseltsev | Upstream:
N/A
Reviewer: Tim Dumol, Marshall Hampton, Karl-Dieter Crisman | Merged:
Work_issues: |
----------------------------------------------------------------+-----------
Changes (by kcrisman):
* status: needs_work => needs_review
Comment:
Hmm, but in many places in this file it says why such things are optional.
In fact, ''earlier in the same docstring'' the first occurrence of
`.show()` explains this:
{{{
sage: a.show() # optional -- requires convert command
}}}
as well as several lines later
{{{
sage: a.show() # optional -- requires convert command
}}}
so hopefully one wouldn't need to do it a third time in three paragraphs.
Especially since it's a `TEST`.
Also, the actual issue with creating a file I have posted to sage-devel
about; it's not 100% clear to me that this is a bug. It just happened to
have a bad effect here, which I changed from Andrey's patch. But it's
orthogonal to the ticket.
So putting back to 'needs review'. I hope you will agree with me that
this is in fact still worthy of positive review.
Now, of course there is in the doctesting framework the issue that one can
do optional tests with only certain keywords, so if one has `convert` one
could run them with that keyword. But in that case, the entire file
`animate.py` is replete with violations of this, and I feel that should be
a separate ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7981#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
