#10596: Misc improvements to integer.pyx
----------------------------------+-----------------------------------------
Reporter: spancratz | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: sage-4.6.2
Component: basic arithmetic | Keywords:
Author: Sebastian Pancratz | Upstream: N/A
Reviewer: Aly Deines | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Changes (by newvalueoldvalue):
* author: spancratz => Sebastian Pancratz
Comment:
Hi Sebastian,
Hope you're well. Trivial comment: it's the done thing to put full names,
not trac usernames, in the Author and Reviewer fields because they're used
for compiling the release notes.
Less trivial: can you perhaps do a micro-patch that gets rid of the unused
variable in ndigits? The rest of the code looks fine to me, and it would
be good to get this positively reviewed soon, because any patch that
changes quite so many lines of code is going to be highly vulnerable to
bitrotting (it already conflicts with my patch at #10625, sigh).
Regards, David
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10596#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
