#10065: removed bug and new methods in Poset
-------------------------------+--------------------------------------------
   Reporter:  stumpc5          |       Owner:  sage-combinat
       Type:  enhancement      |      Status:  needs_review 
   Priority:  minor            |   Milestone:               
  Component:  combinatorics    |    Keywords:  poset        
     Author:  Christian Stump  |    Upstream:  N/A          
   Reviewer:                   |      Merged:               
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by stumpc5):

 * cc: chapoton@… (added)


Comment:

 Replying to [comment:2 chapoton]:

 >  * one doctest is failing (see the report of the build bot). This is
 related to a deprecated use of size instead of cardinality, somewhere.
 Maybe we should correct this deprecated use first.

 I only updated the doctest - the size/cardinality is in generic_graph.py.
 I am in the process to make changes to the is_isomorphic method in there
 anyway. I will make this little change in that other patch.

 >  * it fails on Lattices
 > {{{
 > P=Posets.PentagonPoset()
 > P.is_isomorphic(P)
 > ValueError: The input is not a finite poset.
 > }}}
 >
 > Maybe this can be corrected by having a method '''is_isomorphic''' for
 Lattices which is inherited from Posets.

 This was just a minor mistake in the is_isomorphic method for Posets. I
 updated it.

 > The doc of '''panyushev_orbits''' is badly formatted. It does not
 display correctly in the notebook.

 Done...

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10065#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to