#10549: Improvements in canonical_form, is_isomorphic, and
graph_isom_equivalent_non_edge_labeled_graph
-------------------------------+--------------------------------------------
   Reporter:  stumpc5          |       Owner:  jason, ncohen, rlm               
 
       Type:  enhancement      |      Status:  needs_review                     
 
   Priority:  major            |   Milestone:                                   
 
  Component:  graph theory     |    Keywords:  graph, canonical form, 
isomorphism
     Author:  Christian Stump  |    Upstream:  N/A                              
 
   Reviewer:  Robert Miller    |      Merged:                                   
 
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by rlm):

  * status:  needs_work => needs_review


Old description:

> This ticket implements several improvements in the three method in the
> summary.
>
> Still needs work!

New description:

 This ticket implements several improvements in the three method in the
 summary.

--

Comment:

 The first patch looks very good. Since the ordering of canonical labels
 will now change for multi-edge and edge labeled graphs, this might be
 worth mentioning in the release note. Canonical labels are not in
 principle supposed to be stable from one release to the next, but they
 generally are. So it would be good to warn users about this.

 As a result, I had to change one of the doctests in `species.py` whose
 canonical label is relabeled. I am certainly happy with the first patch,
 so if someone can review my patch, then this ticket can be set to positive
 review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10549#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to