#10061: Fix sig_on/sig_off bugs
------------------------------+---------------------------------------------
   Reporter:  jdemeyer        |       Owner:  tba            
       Type:  defect          |      Status:  positive_review
   Priority:  major           |   Milestone:  sage-4.6.2     
  Component:  c_lib           |    Keywords:  interrupt      
     Author:  Jeroen Demeyer  |    Upstream:  N/A            
   Reviewer:                  |      Merged:                 
Work_issues:                  |  
------------------------------+---------------------------------------------
Changes (by vbraun):

  * status:  needs_review => positive_review


Comment:

 Looks good to me.

 We (i.e. you) should document somewhere very clearly the use of
 {{{
    sig_on()
    c_function()
    sig_off()
 }}}
 vs.
 {{{
    try:
       sig_on()
       cython_function()
    finally:
       sig_off()
 }}}

 In any case, positive review to this ticket.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10061#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to