#727: find rational points on plane conic curves
--------------------------------------------+-------------------------------
Reporter: was | Owner: mstreng
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.6.2
Component: geometry | Keywords: rational point
points conic quadratic form
Author: Nick Alexander, Marco Streng | Upstream: N/A
Reviewer: David Loeffler | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Changes (by davidloeffler):
* status: needs_review => positive_review
* reviewer: => David Loeffler
Comment:
This looks really good. It's embarrassing that we've been shipping Denis
Simon's scripts with Sage for years but nobody's sat down and written the
interface code necessary to make it accessible.
Patch applied fine to 4.6.2.alpha1, all doctests in sage/schemes passed,
the ref manual built OK, and all the examples I tried worked.
I have one minor gripe: there are one or two cases where the new Conic
classes inherit methods from the generic plane curve classes that perhaps
ought to be replaced with more appropriate conic-specific implementations
(e.g the method "rational_points"). But that can come in future tickets if
people feel it's needed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/727#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
