#10450: Problem computing Hecke matrices on subspaces of modular forms spaces
------------------------------+---------------------------------------------
   Reporter:  davidloeffler   |       Owner:  craigcitro    
       Type:  defect          |      Status:  needs_review  
   Priority:  major           |   Milestone:  sage-4.6.2    
  Component:  modular forms   |    Keywords:  hecke operator
     Author:  David Loeffler  |    Upstream:  N/A           
   Reviewer:                  |      Merged:                
Work_issues:                  |  
------------------------------+---------------------------------------------

Comment(by AlexGhitza):

 Great stuff, and good catch on the two missing return statements.

 Of course, these would never have made it in if there were doctests to
 check those parts of the code.  May I suggest adding some now?  Here is an
 easy example:

 {{{
 sage: M = ModularForms(6, 10)
 sage: S = M.cuspidal_submodule()
 sage: W = S.span_of_basis(S.basis()[0:2])
 sage: W.cuspidal_submodule()
 Modular Forms subspace of dimension 2 of Modular Forms space of dimension
 11 for Congruence Subgroup Gamma0(6) of weight 10 over Rational Field
 }}}

 and something along the same lines for {{{eisenstein_submodule}}}.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10450#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to