#10692: new method RootSystem.root_poset
-------------------------------+--------------------------------------------
   Reporter:  stumpc5          |       Owner:  sage-combinat          
       Type:  enhancement      |      Status:  new                    
   Priority:  major            |   Milestone:                         
  Component:  combinatorics    |    Keywords:  root system, root poset
     Author:  Christian Stump  |    Upstream:  N/A                    
   Reviewer:                   |      Merged:                         
Work_issues:                   |  
-------------------------------+--------------------------------------------

Comment(by nthiery):

 Hi Christian!

 Thanks for this useful feature!

 A couple suggestions:

  - Thanks for being careful with potential conflicts with #6588 (so far so
 good :-))
  - I would prefer to call the method as
    RootSystem(["A",3]).root_lattice().root_poset() (possibly with a
 shortcut from root system, to possibly let the user choose in which
 realization the roots are returned
  - The code could be written generically for any RootLatticeRealization by
 computing scalar products with coweights.
  - Even without using scalar products, there should be no need to use
 dict's. Better use instead something like:

 {{{
    for (i,c) in alpha:
        if beta[i] < c: ...
 }}}

  - The root comparison function could be extracted as a separate method,
 as it could be of more general use

 Cheers,
                                  Nicolas

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10692#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to