#10518: Add dot2tex as optional spkg
---------------------------------+------------------------------------------
Reporter: nthiery | Owner: jason, ncohen, rlm
Type: enhancement | Status: positive_review
Priority: major | Milestone:
Component: graph theory | Keywords: graphviz
Author: Nicolas M. Thiéry | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by pang):
* status: needs_review => positive_review
Comment:
I've inspected the package and it looks fine. I've installed it with no
warning.
I've tested it, and it works on the proposed examples. It fails to compile
latex plots of some graphs with non-numeric labels, but this is unrelated
to the package IMHO. The fix would be to either generate better dot code
for those graphs, or configure the latex environment better or in dot2tex
itself. I don't really know and will report a bug when I research a bit
more.
Finally, testing the library after installing the spkg in a 4.6.1 install
that I just updated I got one error that seems completely unrelated (on
"devel/sage/sage/tests/cmdline.py"). A fresh install also fails on that
test.
I'd say this is enough for a positive review, but be my guest.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10518#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
