#10604: Rewrite diagonal matrix constructor
------------------------------+---------------------------------------------
   Reporter:  rbeezer         |       Owner:  ddrake      
       Type:  defect          |      Status:  needs_review
   Priority:  minor           |   Milestone:  sage-4.6.2  
  Component:  linear algebra  |    Keywords:              
     Author:  Rob Beezer      |    Upstream:  N/A         
   Reviewer:  Dan Drake       |      Merged:              
Work_issues:                  |  
------------------------------+---------------------------------------------

Comment(by rbeezer):

 Replying to [comment:20 ddrake]:
 > Can someone who knows the matrix code take a look at my patch? All
 doctests pass with the two patches here applied to 4.6.2.alpha2.

 Thanks, Dan.  I'll look at this more carefully this evening - should have
 time then.

 The root problem here is my decision to return a diagonal matrix as sparse
 since that is exposing a variety of inconsistencies.  If I had it to do
 over....

 Anyway, I suspect `augment()` suffers the same affliction.  I jazzed up
 `augment()` on #10424 with a promise to sync up `stack()` so maybe I
 better make good on that.

 Thanks for the detective work on this one.

 Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10604#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to