#10543: Echelon form over QQ is mutable
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: jason, was
Type: defect | Status: needs_review
Priority: minor | Milestone:
Component: linear algebra | Keywords:
Author: Rob Beezer | Upstream: N/A
Reviewer: Tom Coates | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by rbeezer):
* reviewer: => Tom Coates
Old description:
> Which is not the norm for matrices over other rings.
>
> {{{
> sage: A=matrix(QQ,2,range(4))
> sage: B=matrix(ZZ,2,range(4))
> sage: C=A.echelon_form()
> sage: D=B.echelon_form()
> sage: C.is_mutable()
> True
> sage: D.is_mutable()
> False
> }}}
>
> See http://groups.google.com/group/sage-
> devel/browse_thread/thread/ef90d24da0ee704c
New description:
Which is not the norm for matrices over other rings.
{{{
sage: A=matrix(QQ,2,range(4))
sage: B=matrix(ZZ,2,range(4))
sage: C=A.echelon_form()
sage: D=B.echelon_form()
sage: C.is_mutable()
True
sage: D.is_mutable()
False
}}}
See http://groups.google.com/group/sage-
devel/browse_thread/thread/ef90d24da0ee704c
Apply
trac_10543-rational-echelon-form-immutable.patch, trac_10543-reviewer-
rebased.patch
--
Comment:
Hi Tom,
Thanks for the catch on making a copy of the matrix. Not sure what I was
thinking just then. Your changes look real good to me.
I think your patch ''includes'' my changes and yours mixed together. And
some changes get applied in the echelonize routine (which really had me
scratching my head). I've tried to split out your changes and have placed
a new patch that I belive has just your changes. Except there were some
double-colons needed, including one I'd forgotten. You should give the
revised patch a real close look.
Can you test the whole package? If so, I think you'd be clear to finalize
the review if everything looks OK. It'll need my original patch and then
the rebased reviewer patch. I have tested the pair against the two
affected files and viewed the HTML documentation, and that much looks
good.
Thanks for taking a look at this one and making a fix.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10543#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
