#8977: Bug in QuadraticForm.rational_diagonal_form()
-------------------------------+--------------------------------------------
   Reporter:  gdrama           |       Owner:  justin                  
       Type:  defect           |      Status:  needs_review            
   Priority:  minor            |   Milestone:                          
  Component:  quadratic forms  |    Keywords:  rational_diagonal_form()
     Author:                   |    Upstream:  N/A                     
   Reviewer:                   |      Merged:                          
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by tornaria):

 * cc: jonhanke (added)
  * status:  needs_work => needs_review


Comment:

 I don't think the issue you reported above (about matrix groups
 {{{random_element()}}}) is related in any way to this ticket.

 The patch is pretty straightforward, is almost one-liner, and clearly
 changes only the {{{rational_diagonal_form()}}} method.

 I've just tried on 4.6.1 and:
  a. the bug is reproducible
  b. the doctest in the patch triggers the bug
  c. after applying the patch, the bug is fixed, and the doctest passes.

 ----

 I also tried long-doctesting the {{{matrix_group.py}}} file (with the
 patch applied) but got no error.

 Maybe it's showing randomly for you (and you think it's correlated to the
 patch in this ticket, but is not). Or perhaps something in 4.6.2.alpha3 is
 affecting this.

 ----

 In my opinion, the patch is ready. I'll switch to "needs_review", in the
 hope that somebody else gives the positive review soon.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8977#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to