#10568: multipying sparse matrices by integers in unnecceraly slow
-------------------------------+--------------------------------------------
Reporter: mderickx | Owner: jason, was
Type: enhancement | Status: needs_info
Priority: major | Milestone:
Component: linear algebra | Keywords:
Author: Maarten Derickx | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_info
* author: => Maarten Derickx
Comment:
Maarten,
Looks real good and is a good thing to get into Sage. Seems like sparse
matrices are often neglected. I bet there is more like this to be done in
other places. I used just {{{10568-speedup-QQmatrix-lmul}}}, which I hope
was the right file. Some comments and suggestions follow.
Rob
* I like the HUGE doctest. ;-)
* A doctest like the following might be a nice addition - it'd show a
multiplier outside the base ring cooperating with the coercion model and
doing the right thing.
{{{
sage: F = FiniteField(3)
sage: two = F(2)
sage: A = matrix(ZZ, 3, range(30), sparse=True)
sage: B = two*A; B
[0 2 1 0 2 1 0 2 1 0]
[2 1 0 2 1 0 2 1 0 2]
[1 0 2 1 0 2 1 0 2 1]
sage: B.parent()
Full MatrixSpace of 3 by 10 sparse matrices over Finite Field of size
3
}}}
* How about an {{{INPUT:}}} and {{{OUTPUT:}}} block in the docstring?
Even though these internal methods don't show in tab-completion, you can
still view them in the notebook with formatting, so I think the consistent
style is a good idea.
* If you name your files as {{{*.patch}}} then Trac gives a very nice
red-green/leaving-entering view and my local patch viewer (kompare) will
do tab-completion on the filename. ;-)
* I'd imagine the release manager can clear out the two uploads you
didn't want?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10568#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
