#10530: De Bruijn Sequence construction for combinat
---------------------------------+------------------------------------------
   Reporter:  eviatarbach        |       Owner:  sage-combinat
       Type:  enhancement        |      Status:  needs_review 
   Priority:  major              |   Milestone:  sage-4.6.2   
  Component:  combinatorics      |    Keywords:               
     Author:  Eviatar Bach       |    Upstream:  N/A          
   Reviewer:  Nicolas M. ThiƩry  |      Merged:               
Work_issues:                     |  
---------------------------------+------------------------------------------
Changes (by eviatarbach):

  * status:  needs_work => needs_review


Comment:

 Sorry for taking so long, but here is the updated patch. The changes are
 as follows:

 - sanity-checks the input; corresponding tests added in the docstring
 - filenames changed
 - option for alphabet removed; not really useful and having an additional
 keyword argument may confuse

 I tried to allocate the length of the sequence length beforehand and
 tested with larger inputs, as you suggested, but it is still slower. I
 don't know much about algorithmic efficiency, but that's what I observed
 in my tests. For one input, I got around 50 ms and 120 ms, respectively.

 I decided to not have the sequences as words, to leave the option open for
 generation of all possible sequences open.

 Thanks in advance!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10530#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to