#8800: Doctest coverage of categories - numerous coercion fixes
--------------------------+-------------------------------------------------
   Reporter:  SimonKing   |       Owner:  Simon King         
       Type:  defect      |      Status:  needs_info         
   Priority:  major       |   Milestone:  sage-4.6.2         
  Component:  categories  |    Keywords:  categories doctests
     Author:  Simon King  |    Upstream:  N/A                
   Reviewer:              |      Merged:                     
Work_issues:              |  
--------------------------+-------------------------------------------------
Changes (by lftabera):

  * status:  needs_review => needs_info


Comment:

 Simon,

 What is the reason for the following change?

 {{{
 diff -r f71dd979f978 -r 7097db76160e sage/rings/rational_field.py
 --- a/sage/rings/rational_field.py      Fri Dec 10 14:50:18 2010 +0100
 +++ b/sage/rings/rational_field.py      Wed Jul 21 14:25:41 2010 +0100
 @@ -253,7 +253,7 @@
          import integer_ring
          return FractionField(), integer_ring.ZZ

 -    def completion(self, p, prec, extras = {}):
 +    def completion(self, p, prec, extras):
 }}}

 In the completion method of the RationalField. I think it is an error to
 eliminate the default extras = {}. It is not a mandatory argument neither
 for Qp not for create_RealField and the user has no idea of what to put
 there (QQ.completion has no documentation, which is a bug, but not for
 this ticket)

 Luis

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8800#comment:73>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to