#10751: Upgrading 4.5.3 -> 4.6.2.alpha4 fails
----------------------------+-----------------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.6.2
Component: build | Keywords: cython upgrade dependencies
Author: Volker Braun | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
Comment:
`make -j` without argument to `-j` means: use unlimited number of threads.
Therefore, the code
{{{
pos = MAKE.rfind('-j')
if pos>=0:
nthreads = int(MAKE[pos+2:].split()[0])
}}}
should be changed to
{{{
pos = MAKE.rfind(' -j')
if pos >= 0:
try:
nthreads = int(MAKE[pos+3:].split()[0])
except ValueError:
# If there is no argument to -j, use maximum number of threads
nthreads = 2*cpu_count
}}}
In any case, the `ValueError` must be handled somehow.
Note also that I have added a space before `-j`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10751#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
