#10712: Mark doctests # long time
------------------------------+---------------------------------------------
Reporter: jdemeyer | Owner: mvngu
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.6.2
Component: doctest | Keywords:
Author: Jeroen Demeyer | Upstream: N/A
Reviewer: Rob Beezer | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
* reviewer: => Rob Beezer
Comment:
Replying to [comment:4 rbeezer]:
> * I can see the times given being meaningless to anybody a few years in
the future. 8 seconds? When and where? (Especially if in 3 years
Moore's Law has it running in 2 seconds on new hardware.) Would it be
easy to say "# longtime (8s on sage.math, 2011)"? Could you do that to
the patch with a bit of grep/sed magic?
I could, yes.
> * {{{sage/schemes/elliptic_curves/sha_tate.py}}} had two changes I was
unsure about. First, a test related to #10096 is deleted. Is there a
reason?
The same test appears twice in the same file, exactly the same.
> Second, some tests ("supersingular cases") are claimed to be the
"easiest" possible and a comment to that effect is being deleted.
You mean this:
{{{
# note on the doctests (cw 2010)
# these tests are among the easiest test possible,
# so even if the rank 1 case in supersingular that
# takes more than 20 sec, should not be excluded.
}}}
Well, that comment doesn't make any sense to me and it's also
grammatically wrong. If you think you understand what it means, feel free
to rewrite it.
> I'd even suggest with al the time savings, the rank 1 test could be sent
to the "short time" category? Not everybody runs long tests, so it'd be
good to catch as much possible with the standard suite, and this sounds
like a good candidate.
Fine.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10712#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
