#10723: Implement edge-by-edge options for latexing graphs with dot2tex
---------------------------------+------------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7
Component: graph theory | Keywords: graph, latex, dot2tex
Author: Nicolas M. Thiéry | Upstream: N/A
Reviewer: Rob Beezer | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by nthiery):
* reviewer: => Rob Beezer
Comment:
Hi Robert!
Thanks for your review.
Replying to [comment:10 rbeezer]:
> dot2tex_utils.py, line 95: strips string representation of ``x`` *from*
quotes and newlines.
> Not part of the patch, but while you are here...
> Native speaker advice: I'd say "strip string *of* quotes"
Done.
> generic_graph.py:
>
> line 12199:
> The doctest with the Cayley graph is not very instructive if you do
not know what the (automatically-supplied) labels are - especially if you
don't know any group theory. Maybe just a line or two describing the
graph's labels before you go to work with them?
Done.
> line 12212:
> I did not understand the warning until I re-read one of your emails.
"Collision" suggests to me that one edge is getting two colors (two colors
in the same place). Instead, I think you mean that the "rainbow"
assignments as a default will provide a color to some other edge, which is
identical to a color that is user-supplied for an edge. Is that right? I
think this is a bit "dangerous" - a user could wonder how "their" color
ended up on other edges?
>
> In any event, I really like the rainbow colors for ''all'' of the
edges as a default, but the minute there are some user-supplied colors,
then I think the other edges should get a single default color (probably
black).
Agreed. It now uses the default color.
> graph_latex.py:
>
> line 226: What happens when you try to view(G)? (Answer: I think
this is one of the doctest failures.)
Replaced by a call to latex as above in the same file.
> line 534: I really think {{{color_by_label}}} should be
{{{edge_color_by_label}}}. One might want to do exactly the same thing
with the vertices in the future? Or it should be unambiguous just what is
being colored?
I agree, but this option already exists with that name in
plot/plot3d. So if we decide for this change then this should be done
everywhere at once. I vote for postponing that to #10851.
> Doctests: 4.6.2.alpha4, dot2tex-2.8.7-2, graphviz 2.26.3[[BR]]
> sage -t devel/sage/sage/graphs/graph_plot.py # 12 doctests failed[[BR]]
> sage -t devel/sage/sage/graphs/graph_latex.py # 1 doctests failed[[BR]]
> sage -t devel/sage/sage/graphs/generic_graph.py # 4 doctests
failed[[BR]]
All test pass on my machine with the updated patch I'll upload soon.
If I did not screw up, this is both with and without dot2tex, as well
as with -long and -optional.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10723#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
