#9370: customize printing of elements in CombinatorialFreeModules
-------------------------------+--------------------------------------------
   Reporter:  jhpalmieri       |       Owner:  sage-combinat
       Type:  enhancement      |      Status:  needs_review 
   Priority:  major            |   Milestone:  sage-4.6.2   
  Component:  combinatorics    |    Keywords:               
     Author:  John Palmieri    |    Upstream:  N/A          
   Reviewer:  Christian Stump  |      Merged:               
Work_issues:                   |  
-------------------------------+--------------------------------------------

Comment(by jhpalmieri):

 Replying to [comment:11 stumpc5]:
 > Hi,
 >
 > I will fold #10852 in here, if that's okay.
 >
 > I like the multiple options! I gonna have a more detailed look for a
 review; here are two first comments:
 >
 > 1. Why do you handle the old prefix option extra? Wouldn't it be enough
 to keep the prefix method and return to print_options()[\'prefix\'],
 rather thank keeping _prefix. A complete doctest provided by the buildbot
 can then check if _prefix is used anywhere.

 I think it was just to preserve backward-compatibility, but if you think
 it's safe to remove it, please go ahead.

 > 2. in lines 155p, multiplication is set to ast. Isn't there a way to
 give this argument to the repr_lincomb method? Otherwise, we get the
 following:
 {{{
 sage: A = CombinatorialFreeModule(QQ,['+','*'],scalar_mult='@@')
 sage: A.an_element()
 2@@B['@@'] + 2@@B['+']
 }}}

 Putting it in repr_lincomb would be better, I agree.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9370#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to