#10874: Add support for keep_labels in
Digraph.strongly_connected_components_digraph
---------------------------------+------------------------------------------
Reporter: nthiery | Owner: jason, ncohen, rlm
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.7
Component: graph theory | Keywords: strongly connected components
Author: Nicolas M. Thiéry | Upstream: N/A
Reviewer: Nathann Cohen | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by nthiery):
* status: needs_review => positive_review
Comment:
Hi Nathann,
Wow, that was a quick review! This patch has been basically ready in the
queue since last July; it was time for me to post in on trac :-)
Thanks!
Replying to [comment:2 ncohen]:
> What about avoiding to test "keep_labels" twice ? `:-)`
That was to avoid having ``g.add_vertices(scc_set)`` twice :-)
But it's probably more readable as you did it.
> Here is a reviewer patch which does just that. Your patch is good to go,
so you can set this ticket to "positive review" if you agree with my
modifications, and also if you don't for some reason (please update the
"apply" section in this case) `:-)`
Positive review it is (assuming of course the patch bot confirms that
everything is good; it should).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10874#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
