#10889: make text not give bounding box info if axis_coords is True
-------------------------------+--------------------------------------------
Reporter: jason | Owner: jason, was
Type: defect | Status: needs_info
Priority: major | Milestone: sage-4.7
Component: graphics | Keywords:
Author: Jason Grout | Upstream: N/A
Reviewer: Sébastien Labbé | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by slabbe):
* status: needs_review => needs_info
* reviewer: => Sébastien Labbé
Comment:
Using sage-4.6.1, the patch fixes the problem I was having (mentioned in
[http://groups.google.com/group/sage-
devel/browse_thread/thread/cd980cf5e1901c98 sage-devel]. I added in a new
patch with the following doctest that illustrates that my problem is fixed
:
{{{
sage: P = point([(2008, 167)])
sage: print P.xmin(), P.xmax(), P.ymin(), P.ymax()
2007.0 2009.0 166.0 168.0
sage: P += text('Evolution', (0.5, 0.9), axis_coords=True)
sage: print P.xmin(), P.xmax(), P.ymin(), P.ymax()
2007.0 2009.0 166.0 168.0
}}}
All tests passed on {{{sage/plot/plot.py}}} and {{{sage/plot/text.py}}}.
Before giving a positive review, I have one question. What is the intended
behavior for when `axis_coords` is True and the coordinates are smaller
than 0 or bigger than 1? Do we want to adapt the bounding box? I
personnally already used `axis_coords` to place objects outside the
bounding box... which was previously adapting itself.
{{{
sage: P += text('Evolution', (0.5, 1.4), axis_coords=True)
sage: print P.xmin(), P.xmax(), P.ymin(), P.ymax()
2007.0 2009.0 166.0 168.0
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10889#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
