#10886: DisjointSet: number of sets function
--------------------------------------------------------+-------------------
Reporter: rlm | Owner: jason
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-4.7
Component: misc | Keywords:
Author: Robert Miller | Upstream: N/A
Reviewer: Alexandre Blondin Massé, Sébastien Labbé | Merged:
Work_issues: |
--------------------------------------------------------+-------------------
Changes (by slabbe):
* reviewer: Alexandre Blondin Massé => Alexandre Blondin Massé,
Sébastien Labbé
Comment:
Hi Robert,
Replying to [comment:8 rlm]:
> Can you take a look at the patch and give your opinion? I've made a few
minor changes to the way the classes point at the underlying orbit
partitions, which makes it easier for them to share functionality which
doesn't depend on how the elements are labeled. I think this is the best
"middle path" approach.
>
> -- Robert
I completely agree with the patch. That's a "middle path" I haven't
thought about. Adding this `_nodes` attribute to the class
`DisjointSet_of_hashables` makes it behave like its twin which allow
`cardinality` and `number_of_subsets` methods to jump to the parent.
Thanks for the improvement.
To me it's a positive review (all tests passed, doc is fine).
Sébastien
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10886#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
